feat(ng): use ng lint schematic #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from TSLint to the Angular ESLint schematic by updating configuration files and removing TSLint-specific comments and directives throughout the codebase.
Key changes include:
- Replacing the manual ESLint configuration with Angular ESLint schematic
- Updating package dependencies to use consolidated angular-eslint and typescript-eslint packages
- Removing TSLint comments (
// tslint:disable,// tslint:enable, etc.) from source files - Modernizing TypeScript by removing explicit type annotations where types can be inferred
- Fixing escape sequences in string literals
- Removing empty constructors from components
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/igx-templates/igx-ts/projects/_base/files/package.json | Consolidates ESLint-related dependencies into angular-eslint and typescript-eslint packages |
| packages/igx-templates/igx-ts/projects/_base/files/eslint.config.mjs | Removes manual ESLint configuration file |
| packages/igx-templates/igx-ts/projects/_base/files/eslint.config.js | Adds new ESLint configuration using Angular schematic |
| packages/igx-templates/igx-ts/projects/_base/files/angular.json | Updates lint builder configuration to use default config |
| Multiple component and service files | Removes TSLint comments and empty constructors |
| Multiple index.ts files | Removes explicit boolean type annotations |
| data.ts files | Fixes escaped forward slashes in string literals |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
valadzhov
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1292.